feat(NodeVolumeLimits): return Skip in PreFilter #115398

tangwz · 2023-01-30T14:20:36Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

return Skip in nodevolumelimits PreFilter when the pods that only use secrets and configmaps.

Which issue(s) this PR fixes:

Fixes #114143 #114399

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NodeVolumeLimits implement the PreFilter extension point for skipping the Filter phase if the Pod doesn't use volumes with limits.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2023-01-30T14:20:44Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-01-30T14:20:45Z

Hi @tangwz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kerthcet · 2023-02-03T05:21:17Z

/ok-to-test
sorry for let this sitting a long time.

kerthcet · 2023-02-03T05:22:01Z

/assign

kerthcet · 2023-02-03T06:38:52Z

ping @tangwz can you plz address the test failures at first?

tangwz · 2023-02-06T02:35:24Z

/ok-to-test

k8s-triage-robot · 2023-02-06T03:03:20Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

tangwz · 2023-02-06T03:14:39Z

@kerthcet PTAL

kerthcet · 2023-02-22T10:53:59Z

/assign

mborsz

Thank you!

Just few nits!

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go

alculquicondor · 2023-03-22T17:07:53Z

/cc

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go

alculquicondor · 2023-03-23T14:49:01Z

This needs a release note, because you are adding a PreFilter endpoint.

tangwz · 2023-04-05T11:48:42Z

/cc

Nitpick - please squash the commits into a single one: https://github.com/kubernetes/community/blob/master/contributors/guide/contributing.md#best-practices

If this PR ready to by merged, I'll squash it.

alculquicondor · 2023-04-05T12:23:02Z

It's ok to squash as long as there were no intermediate reviews. But also it's fine to leave it for later.

kerthcet

LGTM with the logics, but left some comments with tests.

pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go

kerthcet · 2023-04-07T15:07:14Z

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go

+			Secret: &v1.SecretVolumeSource{},
+		},
+	}).Obj()
+	notOnlyConfigmapAndSecretPod = st.MakePod().PVC("pvcWithDeletedPV").Volume(v1.Volume{


pvcPodWithConfigmapAndSecret

Also add another two cases covering the PerFilter.

Already has Ephemeral.

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go

tangwz · 2023-04-09T09:28:05Z

/retest

pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go

kerthcet

Can we move oneVolPod to TestEBSLimits as well? Totally LGTM, you can squash now. And sorry for the delayed response because of the kubecon.
/assign @alculquicondor

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go

alculquicondor

/approve
Leaving LGTM to @kerthcet

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go

alculquicondor · 2023-04-24T17:10:11Z

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go

+
+			if gotPreFilterStatus.Code() != framework.Skip {
+				gotStatus := p.Filter(context.Background(), nil, test.newPod, node)
+				if !reflect.DeepEqual(gotStatus, test.wantStatus) {


also refactor these to cmp.Diff in a follow up.

That's ok, I will do.

k8s-ci-robot · 2023-04-24T17:11:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tangwz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/scheduler/OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tangwz · 2023-04-25T14:36:56Z

/retest

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go

tangwz · 2023-04-26T13:36:39Z

@kerthcet PTAL

kerthcet · 2023-04-27T05:47:10Z

/lgtm
Thanks @tangwz

k8s-ci-robot · 2023-04-27T05:47:16Z

LGTM label has been added.

Git tree hash: 7d5aa2eea43979c4b86e9ac0e2bf1ae14877f73e

tosi3k · 2023-04-27T07:40:50Z

/retest

k8s-ci-robot requested review from denkensk and kerthcet January 30, 2023 14:20

k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 30, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2023

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 30, 2023

sanposhiho mentioned this pull request Jan 31, 2023

[Umbrella] Skip Filter plugins when coupled PreFilter plugin returns Skip status #114399

Closed

13 tasks

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2023

k8s-ci-robot assigned kerthcet Feb 3, 2023

k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 6, 2023

mborsz reviewed Mar 22, 2023

View reviewed changes

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go Outdated Show resolved Hide resolved

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go Outdated Show resolved Hide resolved

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go Outdated Show resolved Hide resolved

k8s-ci-robot requested a review from alculquicondor March 22, 2023 17:07

mborsz reviewed Mar 23, 2023

View reviewed changes

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go Outdated Show resolved Hide resolved

pkg/scheduler/framework/plugins/nodevolumelimits/csi.go Outdated Show resolved Hide resolved

tangwz force-pushed the add_NodeVolumeLimits_PreFilter branch from d57fd06 to 07905f0 Compare March 28, 2023 15:24

kerthcet reviewed Apr 7, 2023

View reviewed changes

tangwz force-pushed the add_NodeVolumeLimits_PreFilter branch from ed9efa7 to 5ede346 Compare April 9, 2023 07:46

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 9, 2023

k8s-ci-robot requested review from kerthcet and mborsz April 9, 2023 07:46

alculquicondor reviewed Apr 14, 2023

View reviewed changes

pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go Show resolved Hide resolved

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go Show resolved Hide resolved

kerthcet reviewed Apr 24, 2023

View reviewed changes

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go Show resolved Hide resolved

k8s-ci-robot assigned alculquicondor Apr 24, 2023

alculquicondor reviewed Apr 24, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023

tangwz force-pushed the add_NodeVolumeLimits_PreFilter branch from e464ae7 to 8f99e33 Compare April 25, 2023 13:59

kerthcet reviewed Apr 25, 2023

View reviewed changes

pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go Outdated Show resolved Hide resolved

feat(NodeVolumeLimits): return Skip in PreFilter

8ed8618

tangwz force-pushed the add_NodeVolumeLimits_PreFilter branch from 8f99e33 to 8ed8618 Compare April 26, 2023 12:17

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023

k8s-ci-robot merged commit 87f3acf into kubernetes:master Apr 27, 2023
12 checks passed

k8s-ci-robot added this to the v1.28 milestone Apr 27, 2023

tangwz mentioned this pull request May 2, 2023

[WIP]refactor:(nodevolumelimits): use cmp.Diff for status compare #117715

Closed

kerthcet mentioned this pull request May 27, 2023

Add kerthcet and sanposhiho as SIG scheduling approvers #118294

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(NodeVolumeLimits): return Skip in PreFilter #115398

feat(NodeVolumeLimits): return Skip in PreFilter #115398

tangwz commented Jan 30, 2023 •

edited by k8s-ci-robot

k8s-ci-robot commented Jan 30, 2023

k8s-ci-robot commented Jan 30, 2023

kerthcet commented Feb 3, 2023

kerthcet commented Feb 3, 2023

kerthcet commented Feb 3, 2023

tangwz commented Feb 6, 2023

k8s-triage-robot commented Feb 6, 2023

tangwz commented Feb 6, 2023

kerthcet commented Feb 22, 2023

mborsz left a comment

alculquicondor commented Mar 22, 2023

alculquicondor commented Mar 23, 2023

tangwz commented Apr 5, 2023

alculquicondor commented Apr 5, 2023

kerthcet left a comment

kerthcet Apr 7, 2023

kerthcet Apr 7, 2023

tangwz Apr 9, 2023

tangwz commented Apr 9, 2023

kerthcet left a comment

alculquicondor left a comment

alculquicondor Apr 24, 2023

tangwz Apr 25, 2023

k8s-ci-robot commented Apr 24, 2023

tangwz commented Apr 25, 2023

tangwz commented Apr 26, 2023

kerthcet commented Apr 27, 2023

k8s-ci-robot commented Apr 27, 2023

tosi3k commented Apr 27, 2023

feat(NodeVolumeLimits): return Skip in PreFilter #115398

feat(NodeVolumeLimits): return Skip in PreFilter #115398

Conversation

tangwz commented Jan 30, 2023 • edited by k8s-ci-robot

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Jan 30, 2023

k8s-ci-robot commented Jan 30, 2023

kerthcet commented Feb 3, 2023

kerthcet commented Feb 3, 2023

kerthcet commented Feb 3, 2023

tangwz commented Feb 6, 2023

k8s-triage-robot commented Feb 6, 2023

tangwz commented Feb 6, 2023

kerthcet commented Feb 22, 2023

mborsz left a comment

Choose a reason for hiding this comment

alculquicondor commented Mar 22, 2023

alculquicondor commented Mar 23, 2023

tangwz commented Apr 5, 2023

alculquicondor commented Apr 5, 2023

kerthcet left a comment

Choose a reason for hiding this comment

kerthcet Apr 7, 2023

Choose a reason for hiding this comment

kerthcet Apr 7, 2023

Choose a reason for hiding this comment

tangwz Apr 9, 2023

Choose a reason for hiding this comment

tangwz commented Apr 9, 2023

kerthcet left a comment

Choose a reason for hiding this comment

alculquicondor left a comment

Choose a reason for hiding this comment

alculquicondor Apr 24, 2023

Choose a reason for hiding this comment

tangwz Apr 25, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 24, 2023

tangwz commented Apr 25, 2023

tangwz commented Apr 26, 2023

kerthcet commented Apr 27, 2023

k8s-ci-robot commented Apr 27, 2023

tosi3k commented Apr 27, 2023

tangwz commented Jan 30, 2023 •

edited by k8s-ci-robot