New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoints and EndpointSlices should not publish IPs for terminal pods #110255
Conversation
pods on phase succeeded or failed are guaranteed to have all containers stopped and to not ever regress
Terminal pods, whose phase its Failed or Succeeded, are guaranteed to never regress and to be stopped, so their IPs never should be published on the Endpoints.
@robscott: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks - is it important to merge this so you can start cherrypicks? Or should we just wait for Antonio to update? |
@thockin I'd been hoping to get cherry picks going today if possible, but this can wait until next week if needed. |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@robscott: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…0255-upstream-release-1.22 Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods
…0255-upstream-release-1.23 Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods
…0255-upstream-release-1.24 Automated cherry pick of #110255: Endpoints and EndpointSlices should not publish IPs for terminal pods
update release-note for cherry-picks of #110255
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since 1.22 the pod phase lifecycle guarantees that terminal pods, those whose states are Unready or Succeeded , can not regress and will have all container stopped. Hence, terminal PodIPs will never been able to be reachable and should not be published on the endpoints or endpoints slices, independently of the TolerateUnready option
Which issue(s) this PR fixes:
Fixes: #109414, #109718
Special notes for your reviewer:
This is identical to @aojea's earlier PR (#110115) with one additional commit tacked on to resolve the final bits of feedback. I'm fine to just incorporate these into the original PR if that's easier, just want to get this fix in ASAP.
Does this PR introduce a user-facing change?
/sig network
/priority important-soon
/cc @aojea @bowei @swetharepakula
/assign @smarterclayton @thockin