Switch events history to use LRU cache instead of map #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,7 @@ package record | |||
| import ( | |||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/api" | |||
| "github.com/GoogleCloudPlatform/kubernetes/pkg/util" | |||
| "github.com/golang/groupcache/lru" | |||
| "sync" | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
History probably didn't need to be exposed outside the package? Consider making it lower-case?
|
Thanks for the feedback Eric! PTAL. I think I'll create a follow-up PR, to break the cache out in to it's own package, and make it more generic. |
saad-ali
force-pushed
the
eventsCacheLru
branch
from
61add8e
to
2735e6a
Compare
|
LGTM I suggested that next time, you have dep library as a separate commit. Thanks! |
erictune
added a commit
that referenced
this pull request
Feb 18, 2015
Switch events history to use LRU cache instead of map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently events history cache uses a map for tracking previously seen events. This means if the component (e.g. kubelet) runs for a long period of time and generates a ton of unique events, the hash table could grow very large in memory.
To prevent this from happening, this PR switches the events history cache to use a LRU cache. When the max num of entries is hit, it starts evicting the oldest entries.
I arbitrarily set the
maxLruCacheEntriesto4096; let me know if you think this would be too high/low, etc.Will update documentation (PR #4372) accordingly, once this is merged.
cc @dchen1107 @erictune